From f313852e91a596e2f06cf008568e6adf08bf5ffd Mon Sep 17 00:00:00 2001 From: Keir Fraser Date: Sat, 12 May 2007 12:46:26 +0100 Subject: [PATCH] vmx: Replace pointless test-then-set with set. Spotted by Eddie Dong. Signed-off-by: Keir Fraser --- xen/arch/x86/hvm/vmx/vmx.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index ea20a8cfd2..dfc4ad6431 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -101,12 +101,11 @@ static void vmx_save_host_msrs(void) rdmsrl(msr_index[i], host_msr_state->msrs[i]); } -#define WRITE_MSR(address) \ - guest_msr_state->msrs[VMX_INDEX_MSR_ ## address] = msr_content; \ - if ( !test_bit(VMX_INDEX_MSR_ ## address, &guest_msr_state->flags) )\ - set_bit(VMX_INDEX_MSR_ ## address, &guest_msr_state->flags); \ - wrmsrl(MSR_ ## address, msr_content); \ - set_bit(VMX_INDEX_MSR_ ## address, &host_msr_state->flags); \ +#define WRITE_MSR(address) \ + guest_msr_state->msrs[VMX_INDEX_MSR_ ## address] = msr_content; \ + set_bit(VMX_INDEX_MSR_ ## address, &guest_msr_state->flags); \ + wrmsrl(MSR_ ## address, msr_content); \ + set_bit(VMX_INDEX_MSR_ ## address, &host_msr_state->flags); \ break static inline int long_mode_do_msr_read(struct cpu_user_regs *regs) -- 2.30.2